Skip to content

Create README.md #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

Create README.md #6642

merged 1 commit into from
Oct 30, 2022

Conversation

devesh-0419
Copy link
Contributor

@devesh-0419 devesh-0419 commented Oct 4, 2022 •
edited
Loading

for blockchain file

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@devesh-0419
Create README.md
12efb6e 
for blockchain file
CaedenPH
CaedenPH approved these changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss Looks good to me

@cclauss cclauss merged commit ba576a9 into TheAlgorithms:master Oct 30, 2022
@GK3077
Copy link
Contributor

GK3077 commented Nov 6, 2022

Hi, Is that fine if I add some more content for the Document for deeper explanation

@cclauss
Copy link
Member

cclauss commented Nov 6, 2022 •
edited
Loading

@GK3077 Please create a pull request so we can evaluate what you have in mind.

@GK3077
Copy link
Contributor

GK3077 commented Nov 6, 2022

Hi, Added information as far as I could. pr #7974. Previous PRs were auto closed as images for illustration were not accepted.

@GK3077
Copy link
Contributor

GK3077 commented Nov 6, 2022

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devesh-0419 @GK3077 @cclauss @CaedenPH